src/components/mui/sponsor-addon-select.js-14-26 (1)

14-26: ⚠️ Potential issue | 🟡 Minor

Refetch when sponsor/summit props change and guard missing sponsorships.

Lines 14-26: The effect runs only once with an empty dependency array, so changes to sponsor or summitId won't trigger a refetch. Additionally, accessing sponsor.sponsorships without optional chaining will crash if sponsorships is unset. The debug log should also be removed.

🔧 Suggested fix

-  const sponsorshipIds = sponsor.sponsorships.map((e) => e.id);
+  const sponsorshipIds = sponsor?.sponsorships?.map((e) => e.id) ?? [];

   useEffect(() => {
-    querySponsorAddons(summitId, sponsor.id, sponsorshipIds,(results) => {
-      console.log("RESULTS: ", results);
+    if (!sponsor?.id || sponsorshipIds.length === 0) {
+      setOptions([]);
+      return;
+    }
+    querySponsorAddons(summitId, sponsor.id, sponsorshipIds, (results) => {
       const normalized = results.map((r) => ({
         value: r.id,
         label: r.name
       }));
       setOptions(normalized);
     });
-  }, []);
+  }, [summitId, sponsor?.id, sponsorshipIds.join(",")]);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/mui/sponsor-addon-select.js` around lines 14 - 26, The effect
currently runs only once and reads sponsor.sponsorships unsafely and logs debug
output; fix by moving the sponsorshipIds computation into the useEffect, guard
sponsorships with optional chaining or a default (e.g., const sponsorshipIds =
sponsor?.sponsorships?.map(e => e.id) || []), remove the console.log, and update
the useEffect dependency array to include summitId and the sponsor (or
sponsor.id and sponsor.sponsorships) so querySponsorAddons is re-run when those
props change; keep setOptions and the normalized mapping as-is and call
querySponsorAddons(summitId, sponsor.id, sponsorshipIds, ...) inside the updated
effect.

src/components/mui/summit-addon-select.js-15-23 (1)

15-23: ⚠️ Potential issue | 🟡 Minor

Add summitId to the effect dependency array to refetch addons when the summit changes.

Lines 15-23: The effect runs only on mount with an empty dependency array, so if the summitId prop changes, the component will display stale addon options. Add summitId as a dependency to ensure the effect re-runs when the summit changes.

🔧 Suggested fix

  useEffect(() => {
    querySummitAddons(summitId, (results) => {
      const normalized = results.map((r) => ({
        value: r,
        label: r
      }));
      setOptions(normalized);
    });
-  }, []);
+  }, [summitId]);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/mui/summit-addon-select.js` around lines 15 - 23, The
useEffect that calls querySummitAddons currently has an empty dependency array
and will not refetch when summitId changes; update the effect for the component
(the useEffect that invokes querySummitAddons and calls setOptions) to include
summitId in its dependency array so the effect re-runs whenever the summitId
prop changes, ensuring options are reloaded for the new summit.

src/pages/sponsors/sponsor-cart-tab/components/cart-view.js-47-49 (1)

47-49: ⚠️ Potential issue | 🟡 Minor

Remove or convert debug console.log statements.

Multiple handlers contain placeholder console.log statements that should be removed or replaced with actual implementation before merging. This aligns with the PR title noting "WIP".

Also applies to: 59-65

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/pages/sponsors/sponsor-cart-tab/components/cart-view.js` around lines 47
- 49, The debug console.log in handleManageItems should be removed and replaced
with the real implementation or a call to the existing cart update handlers;
specifically update the handleManageItems function to perform the intended
action (e.g., open a manage modal, dispatch an action, or call functions like
removeItem/updateQuantity) instead of logging, and likewise remove/replace any
other placeholder console.log statements in the nearby handlers (the handlers
around lines 59-65) with their proper implementations or calls to shared
utilities so no debug logs remain.

src/components/mui/FormItemTable/components/ItemTableField.js-13-79 (1)

13-79: ⚠️ Potential issue | 🟡 Minor

Missing default case in switch statement.

The switch statement doesn't handle unknown field.type values, causing the function to implicitly return undefined. This could cause silent rendering failures for unrecognized field types.

Proposed fix to add default case

     case "TextArea":
       return (
         <MuiFormikTextField
           name={name}
           label={label}
           fullWidth
           size="small"
           multiline
           rows={3}
         />
       );
+    default:
+      console.warn(`Unknown field type: ${field.type}`);
+      return null;
   }
 };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/mui/FormItemTable/components/ItemTableField.js` around lines
13 - 79, The switch over field.type in the ItemTableField component lacks a
default branch, so unknown field.type values cause an implicit undefined render;
add a default case to the switch (in the same switch handling "CheckBox",
"CheckBoxList", "RadioButtonList", etc.) that returns a safe fallback (e.g.,
null) and logs a warning with the offending field.type (use console.warn or your
app logger) so unrecognized types fail loudly instead of producing silent
rendering errors.

src/components/mui/formik-inputs/mui-formik-dropdown-checkbox.js-16-18 (1)

16-18: ⚠️ Potential issue | 🟡 Minor

Edge case: allSelected is true when options is empty.

Array.every() returns true for an empty array. If options is empty, allSelected will be true, causing the "All" checkbox to appear checked and renderValue to show "All" text even though nothing is actually selected.

Proposed fix

-  const allSelected = options.every(({ value }) =>
-    field.value?.includes(value)
-  );
+  const allSelected = options.length > 0 && options.every(({ value }) =>
+    field.value?.includes(value)
+  );

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/mui/formik-inputs/mui-formik-dropdown-checkbox.js` around
lines 16 - 18, The bug is that allSelected is true when options is empty because
Array.every returns true for empty arrays; update the allSelected calculation in
mui-formik-dropdown-checkbox.js (the allSelected constant) to require
options.length > 0 and that field.value is an array before checking every option
(e.g., guard with options.length > 0 && Array.isArray(field.value) &&
options.every(({ value }) => field.value.includes(value))) so the "All" checkbox
and renderValue only show "All" when there are options and they are actually all
selected.

src/pages/sponsors/sponsor-cart-tab/components/edit-form.js-1-9 (1)

1-9: ⚠️ Potential issue | 🟡 Minor

Placeholder file with unused imports should be removed or repurposed.

This file defines an EditForm component that returns null and imports unused React and T. Meanwhile, the actual EditForm implementation exists at src/pages/sponsors/sponsor-cart-tab/components/edit-form/edit-form.js. This placeholder may cause import confusion.

If this file is intended as a barrel/re-export, update it to re-export from the actual implementation. Otherwise, consider removing it.

Option 1: Convert to re-export

-import React from "react";
-import T from "i18n-react/dist/i18n-react";
-
-const EditForm = () => {
-
-  return null;
-}
-
-export default EditForm;
+export { default } from "./edit-form/edit-form";

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/pages/sponsors/sponsor-cart-tab/components/edit-form.js` around lines 1 -
9, This placeholder EditForm component imports React and T but returns null and
shadows the real implementation; either remove this file and update any imports
to point to the real component, or turn it into a simple re-export of the real
implementation (stop importing unused React/T and export the default from the
actual edit-form implementation so consumers resolve correctly). Locate the
symbol EditForm in this file and replace the body with a re-export of the real
implementation (or delete the file) and run a quick search to update any broken
imports.

src/components/mui/FormItemTable/components/GlobalQuantityField.js-14-17 (1)

14-17: ⚠️ Potential issue | 🟡 Minor

Missing helpers in useEffect dependency array.

The effect uses helpers.setValue and helpers.setTouched but doesn't include helpers in the dependency array. This could cause stale closure issues. Additionally, unconditionally setting touched: true on value changes may display validation errors before user interaction.

Proposed fix

   useEffect(() => {
     helpers.setValue(value);
-    helpers.setTouched(true);
-  }, [value]);
+    // Only mark as touched if the value actually changed from user interaction
+  }, [value, helpers]);

Note: The eslint-disable comment suggests this was intentionally omitted, but could cause issues if helpers reference changes.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/mui/FormItemTable/components/GlobalQuantityField.js` around
lines 14 - 17, The effect currently uses helpers.setValue and helpers.setTouched
but only lists [value] as a dependency which can lead to stale closures; update
the useEffect to include helpers in its dependency array (e.g., [value,
helpers]) and stop unconditionally calling helpers.setTouched(true) on every
value change — either remove the setTouched call so programmatic updates don't
mark the field touched, or guard it behind an explicit condition/prop (e.g.,
only mark touched for user-driven changes). Ensure you update the effect around
the existing useEffect that references helpers.setValue and helpers.setTouched.

src/pages/sponsors/sponsor-cart-tab/components/cart-view.js-136-136 (1)

136-136: ⚠️ Potential issue | 🟡 Minor

Hardcoded English string breaks internationalization.

The text "forms in Cart" is hardcoded while the rest of the component uses T.translate(). This should use a translation key for consistency.

Proposed fix

-          <Box component="span">{cart?.forms.length} forms in Cart</Box>
+          <Box component="span">
+            {T.translate("edit_sponsor.cart_tab.forms_in_cart", { count: cart?.forms.length })}
+          </Box>

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/pages/sponsors/sponsor-cart-tab/components/cart-view.js` at line 136,
Replace the hardcoded English label inside the Box component so it uses the app
i18n helper like the other strings: call T.translate with an appropriate key
(e.g., "sponsors.cart.formsInCart") and interpolate cart?.forms.length into that
localized message instead of the literal "forms in Cart"; update the usage near
the Box component that currently renders {cart?.forms.length} forms in Cart to
use T.translate(...) and pass the count as a variable so translations can render
pluralization/localized text correctly.

src/pages/sponsors/sponsor-cart-tab/components/select-form-dialog/index.js-57-64 (1)

57-64: ⚠️ Potential issue | 🟡 Minor

State not reset when dialog closes via backdrop/escape.

The Dialog's onClose prop calls onClose directly (Line 111), bypassing handleClose which resets selectedRows. Additionally, selectedAddon is never reset. This causes stale selections when the dialog reopens.

🐛 Proposed fix

   const handleClose = () => {
     setSelectedRows([]);
+    setSelectedAddon(null);
     onClose();
   };

   // ...

-    <Dialog open={open} onClose={onClose} maxWidth="md" fullWidth>
+    <Dialog open={open} onClose={handleClose} maxWidth="md" fullWidth>

Also applies to: 111-111

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/pages/sponsors/sponsor-cart-tab/components/select-form-dialog/index.js`
around lines 57 - 64, The Dialog's onClose currently calls onClose directly,
bypassing handleClose so selectedRows and selectedAddon aren't reset; change the
Dialog to use handleClose for its onClose handler and update handleClose (and
any other close paths like confirm/cancel handlers) to reset both selectedRows
and selectedAddon (e.g., setSelectedRows([]) and
setSelectedAddon(null/initialValue)) before calling onClose(), and ensure
handleOnCheck continues to set selectedRows as before.

src/components/mui/FormItemTable/__tests__/FormItemTable.test.js-446-452 (1)

446-452: ⚠️ Potential issue | 🟡 Minor

Property name mismatch in test mock data.

The test uses class: "Form" but the ItemTableField component constructs the field name using field.class_field (see relevant snippet line 10: const name = \i-${rowId}-c-${field.class_field}-f-${field.type_id}`;`). This inconsistency will cause the test to not render inputs with the expected test IDs.

🐛 Proposed fix

           meta_fields: [
             {
               type_id: 100,
-              class: "Form",
+              class_field: "Form",
               name: "Description",
               type: "Text"
             }
           ]

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/mui/FormItemTable/__tests__/FormItemTable.test.js` around
lines 446 - 452, The mock field in the test uses "class" whereas the component
(ItemTableField) reads field.class_field to build the input name (const name =
`i-${rowId}-c-${field.class_field}-f-${field.type_id}`), so update the test
fixture to include a class_field property (e.g. class_field: "Form") or rename
the existing "class" key to "class_field" so the generated test IDs match and
the inputs render correctly.

src/components/mui/FormItemTable/__tests__/FormItemTable.test.js-19-23 (1)

19-23: ⚠️ Potential issue | 🟡 Minor

Property name mismatch in MOCK_RATE_DATES.

The mock uses onsite_end_date but the FormItemTable component expects onsite_price_end_date based on the relevant code snippet (lines 45-47 in FormItemTable/index.js). This mismatch will cause the onsite rate logic to behave unexpectedly in tests.

🐛 Proposed fix

 const MOCK_RATE_DATES = {
   early_bird_end_date: EARLY_BIRD_DATE,
   standard_price_end_date: STANDARD_DATE,
-  onsite_end_date: ONSITE_DATE
+  onsite_price_end_date: ONSITE_DATE
 };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/mui/FormItemTable/__tests__/FormItemTable.test.js` around
lines 19 - 23, The mock object MOCK_RATE_DATES uses the wrong property name for
the onsite date; update MOCK_RATE_DATES so the key matches what FormItemTable
expects (onsite_price_end_date) instead of onsite_end_date, keeping
EARLY_BIRD_DATE and STANDARD_DATE mapped to early_bird_end_date and
standard_price_end_date respectively; this ensures the FormItemTable logic that
reads onsite_price_end_date will get ONSITE_DATE from the test fixture.

src/components/mui/FormItemTable/__tests__/FormItemTable.test.js-558-578 (1)

558-578: ⚠️ Potential issue | 🟡 Minor

Incorrect property name used in rate highlighting tests.

The tests use MOCK_RATE_DATES.early_bird_rate and MOCK_RATE_DATES.standard_rate, but MOCK_RATE_DATES is defined with early_bird_end_date and standard_price_end_date properties. This will result in accessing undefined values, causing the tests to not behave as intended.

🐛 Proposed fix

     it("highlights standard rate when current time is between early_bird and standard", () => {
       jest
         .spyOn(Date, "now")
         .mockImplementation(
           () =>
-            (MOCK_RATE_DATES.early_bird_rate + TIME_OFFSET) *
+            (MOCK_RATE_DATES.early_bird_end_date + TIME_OFFSET) *
             MILLISECONDS_MULTIPLIER
         );
       // ...
     });

     it("highlights onsite rate when current time is after standard_rate", () => {
       jest
         .spyOn(Date, "now")
         .mockImplementation(
           () =>
-            (MOCK_RATE_DATES.standard_rate + TIME_OFFSET) *
+            (MOCK_RATE_DATES.standard_price_end_date + TIME_OFFSET) *
             MILLISECONDS_MULTIPLIER
         );
       // ...
     });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/mui/FormItemTable/__tests__/FormItemTable.test.js` around
lines 558 - 578, The test is referencing non-existent properties on
MOCK_RATE_DATES (early_bird_rate and standard_rate); update the test to use the
correct properties (early_bird_end_date and standard_price_end_date) when
building the mocked Date.now value used in the "highlights standard rate..."
spec (the Date.now mock in the test and any other tests referencing those wrong
keys), or alternatively adjust MOCK_RATE_DATES to include the expected keys;
ensure the Date.now mock multiplies the correct end-date field by
MILLISECONDS_MULTIPLIER so the time comparison in FormItemTable rendering uses
real values.

src/pages/sponsors/sponsor-cart-tab/components/edit-form/edit-form.js (1)

126-129: Use .forEach() instead of .map() for side effects.

Using .map() when the return value is not used is misleading. These iterations are purely for side effects (building accumulator objects), so .forEach() is more appropriate.

Proposed fix

 const buildInitialValues = (items, timeZone) =>
   items.reduce((acc, item) => {
-    item.meta_fields.map((f) => {
+    item.meta_fields.forEach((f) => {
       acc[`i-${item.form_item_id}-c-${f.class_field}-f-${f.type_id}`] =
         parseValue(f, timeZone);
     });
     // ...
   }, {});

 const buildValidationSchema = (items, t) =>
   items.reduce((acc, item) => {
     item.meta_fields
       .filter((f) => f.class_field === "Form")
-      .map((f) => {
+      .forEach((f) => {
         acc[`i-${item.form_item_id}-c-${f.class_field}-f-${f.type_id}`] =
           getYupValidation(f, t);
       });
     // ...
   }, {});

Also applies to: 142-145

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/pages/sponsors/sponsor-cart-tab/components/edit-form/edit-form.js` around
lines 126 - 129, Replace uses of .map() that are used only for side effects with
.forEach() to avoid misleading code: change item.meta_fields.map((f) => { ... })
to item.meta_fields.forEach((f) => { ... }) in the accumulator-building blocks
(the snippet using
acc[`i-${item.form_item_id}-c-${f.class_field}-f-${f.type_id}`] = parseValue(f,
timeZone);) and apply the same change for the similar occurrence around the
other block (the code at the second occurrence that mirrors lines 142-145).

src/components/mui/FormItemTable/index.js (2)

80-86: calculateTotal is not memoized, causing potential performance issues.

calculateTotal is a regular function that gets recreated on every render and is used in totalAmount useMemo. Since it's not stable, changes to unrelated state could trigger unnecessary recalculations.

Consider memoizing calculateTotal

-  const calculateTotal = (row) => {
+  const calculateTotal = useCallback((row) => {
     const qty =
       values[`i-${row.form_item_id}-c-global-f-quantity`] ||
       calculateQuantity(row);
     if (currentApplicableRate === "expired") return 0;
     return qty * row.rates[currentApplicableRate];
-  };
+  }, [values, calculateQuantity, currentApplicableRate]);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/mui/FormItemTable/index.js` around lines 80 - 86,
calculateTotal is recreated each render which invalidates the totalAmount
useMemo; wrap calculateTotal in React.useCallback so it is stable between
renders (keep its signature calculateTotal(row)), and include as dependencies:
currentApplicableRate, values, and calculateQuantity (and any other helper it
uses). Ensure you reference the same calculateTotal in the totalAmount useMemo
so the memo depends on the stable callback rather than a new function each
render.

---

64-78: calculateQuantity dependency on valuesStr may cause stale closures.

The useCallback depends on valuesStr (stringified values) but references extraColumns directly. If extraColumns changes without valuesStr changing, the callback will use stale extraColumns. Also, stringifying the entire values object on every render for dependency comparison is inefficient.

Proposed fix

   const calculateQuantity = useCallback(
     (row) => {
       const qtyEXC = extraColumns.filter((exc) => exc.type === "Quantity");
       return qtyEXC.reduce((res, exc) => {
         const start = res > 0 ? res : 1;
         return (
           start *
           (values?.[
             `i-${row.form_item_id}-c-${exc.class_field}-f-${exc.type_id}`
           ] || 0)
         );
       }, 0);
     },
-    [valuesStr]
+    [values, extraColumns]
   );

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/mui/FormItemTable/index.js` around lines 64 - 78, The
calculateQuantity callback currently lists only valuesStr as a dependency and
reads extraColumns and values directly, which can produce stale closures; update
the useCallback dependencies to include extraColumns and values (or a stable
memoized reference to values) instead of relying on valuesStr stringification,
or memoize extraColumns where it’s created and then include that memoized
symbol; ensure the dependency array is [values, extraColumns] (or
[memoizedValues, memoizedExtraColumns]) so calculateQuantity always sees the
latest extraColumns and values.

src/components/mui/formik-inputs/mui-formik-dropdown-checkbox.js (1)

35-72: Missing validation error display for users.

The component binds error={meta.touched && Boolean(meta.error)} to FormControl, which sets error styling, but doesn't render the actual error message. Other similar components (e.g., MuiFormikCheckbox) include a FormHelperText to display the error text.

Proposed fix to display validation errors

+import {
+  Checkbox,
+  Divider,
+  FormControl,
+  FormHelperText,
+  ListItemText,
+  MenuItem,
+  Select
+} from "@mui/material";
...
       </Select>
+      {meta.touched && meta.error && (
+        <FormHelperText>{meta.error}</FormHelperText>
+      )}
     </FormControl>

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/mui/formik-inputs/mui-formik-dropdown-checkbox.js` around
lines 35 - 72, The FormControl is marking errors via error={meta.touched &&
Boolean(meta.error)} but the component (MuiFormikDropdownCheckbox) never renders
the error text; add a FormHelperText under the Select that displays the
validation message when meta.touched && meta.error is truthy (e.g.,
<FormHelperText>{meta.touched && meta.error}</FormHelperText>), and ensure
FormHelperText is imported from `@mui/material` so the visual error text matches
the FormControl error state.

src/pages/sponsors/sponsor-cart-tab/components/cart-view.js (1)

35-37: Missing getSponsorCart in useEffect dependency array.

The effect calls getSponsorCart() but doesn't include it in the dependency array. While this works due to how connect works, adding it follows React hooks best practices and prevents lint warnings.

Proposed fix

   useEffect(() => {
     getSponsorCart();
-  }, []);
+  }, [getSponsorCart]);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/pages/sponsors/sponsor-cart-tab/components/cart-view.js` around lines 35
- 37, The useEffect invoking getSponsorCart is missing getSponsorCart in its
dependency array; update the useEffect that calls getSponsorCart to include
getSponsorCart in the deps so React hooks linters are satisfied, and if
getSponsorCart is not a stable reference (e.g., coming from props via
mapDispatchToProps or recreated each render) make it stable by memoizing it
(move to a stable mapDispatchToProps, wrap it in useCallback where defined, or
otherwise ensure the reference is stable) before adding to the dependency array.

src/pages/sponsors/sponsor-cart-tab/components/select-form-dialog/index.js (2)

173-177: Incomplete PropTypes definition.

Several props are used but not declared in PropTypes: availableForms, sponsor, open, and getSponsorFormsForCart. This reduces type safety and developer experience.

♻️ Suggested improvement

 SelectFormDialog.propTypes = {
+  availableForms: PropTypes.shape({
+    forms: PropTypes.array,
+    currentPage: PropTypes.number,
+    term: PropTypes.string,
+    order: PropTypes.string,
+    orderDir: PropTypes.number,
+    total: PropTypes.number
+  }).isRequired,
   summitId: PropTypes.number.isRequired,
+  sponsor: PropTypes.shape({}).isRequired,
+  open: PropTypes.bool.isRequired,
   onClose: PropTypes.func.isRequired,
-  onSave: PropTypes.func.isRequired
+  onSave: PropTypes.func.isRequired,
+  getSponsorFormsForCart: PropTypes.func.isRequired
 };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/pages/sponsors/sponsor-cart-tab/components/select-form-dialog/index.js`
around lines 173 - 177, SelectFormDialog.propTypes is missing several props used
by the component; add PropTypes entries for availableForms (array.isRequired or
array), sponsor (object.isRequired or shape), open (bool.isRequired), and
getSponsorFormsForCart (func.isRequired) to match how they're used. Update the
SelectFormDialog.propTypes declaration to include these keys with appropriate
PropTypes types (e.g., PropTypes.array, PropTypes.object or PropTypes.shape,
PropTypes.bool, PropTypes.func) and mark as required where the component depends
on them.

---

38-40: Missing dependency in useEffect.

The getSponsorFormsForCart function from props should be included in the dependency array. While it's a Redux-bound action creator that typically doesn't change, including it follows React's exhaustive-deps rule and prevents potential stale closure issues.

♻️ Suggested improvement

   useEffect(() => {
     getSponsorFormsForCart();
-  }, []);
+  }, [getSponsorFormsForCart]);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/pages/sponsors/sponsor-cart-tab/components/select-form-dialog/index.js`
around lines 38 - 40, The useEffect that calls getSponsorFormsForCart is missing
getSponsorFormsForCart in its dependency array; update the effect in
select-form-dialog's component so the dependency array includes
getSponsorFormsForCart (or alternatively ensure the prop is stable by wrapping
the action in useCallback where it's defined) to satisfy exhaustive-deps and
avoid stale closures—specifically modify the useEffect that currently calls
getSponsorFormsForCart() to depend on getSponsorFormsForCart.

src/pages/sponsors/sponsor-cart-tab/index.js (1)

24-29: No mechanism to exit edit mode.

There's no handler to set formEdit back to null after editing is complete or cancelled. The EditForm component's cancel button calls navigate(-1) (based on relevant snippet), which navigates away rather than returning to the cart view within this tab.

♻️ Suggested approach

Consider adding an onCancel or onComplete callback to EditForm that resets formEdit:

+  const handleEditComplete = () => {
+    setFormEdit(null);
+  };

   // ...

-      {formEdit && <EditForm form={formEdit} />}
+      {formEdit && (
+        <EditForm
+          form={formEdit.form}
+          addOnId={formEdit.addOnId}
+          onCancel={handleEditComplete}
+          onSave={handleEditComplete}
+        />
+      )}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/pages/sponsors/sponsor-cart-tab/index.js` around lines 24 - 29, The
component lacks a way to exit edit mode because formEdit is never reset; add a
handler (e.g., handleCloseEdit or handleCancelEdit) that calls setFormEdit(null)
and pass it into the EditForm as an onCancel/onComplete prop so the EditForm can
invoke it when the user cancels or finishes editing; also update EditForm usage
to call this callback instead of relying on navigate(-1) (or call
setFormEdit(null) alongside navigation) and ensure handleAddForm still sets
formEdit({ form, addOnId }) as before.

src/components/mui/ItemSettingsModal/index.js (1)

72-76: Declare timeZone in PropTypes for clarity.

It’s used by ItemTableField, so documenting it avoids silent misuse.

🔧 Suggested fix

 ItemSettingsModal.propTypes = {
   item: PropTypes.object.isRequired,
+  timeZone: PropTypes.string,
   open: PropTypes.bool.isRequired,
   onClose: PropTypes.func.isRequired
 };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/mui/ItemSettingsModal/index.js` around lines 72 - 76, Add the
missing timeZone PropType to the ItemSettingsModal component: update
ItemSettingsModal.propTypes to include timeZone (e.g.,
PropTypes.string.isRequired or PropTypes.string) since ItemTableField consumes
it; locate the ItemSettingsModal.propTypes block and add the timeZone entry with
the appropriate required/optional setting to match how ItemTableField expects
it.

src/components/mui/FormItemTable/index.js (2)

37-41: Guard against empty data array before accessing data[0].

While data[0]?.meta_fields?.filter handles undefined gracefully, other parts of the component (e.g., data.map on line 131) assume data is a non-empty array. Consider adding an early return or guard clause.

 const FormItemTable = ({
   data,
   rateDates,
   timeZone,
   values,
   onNotesClick,
   onSettingsClick
 }) => {
+  if (!data || data.length === 0) {
+    return null;
+  }
+
   const valuesStr = JSON.stringify(values);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/mui/FormItemTable/index.js` around lines 37 - 41, The
component assumes `data` is a non-empty array (e.g., computing
extraColumns/totalColumns and later using data.map in the component) which can
lead to runtime errors; add a guard at the top of the component to handle
empty/undefined `data` (return null/placeholder or an empty table) before
computing valuesStr/extraColumns/fixedColumns/totalColumns and before calling
data.map, or default `data` to an empty array and short-circuit rendering when
data.length === 0 to ensure the rest of the logic (including valuesStr,
extraColumns and the data.map usage) is safe.

---

86-92: calculateTotal accesses values directly but is not memoized.

This function is called during render (line 98 and 200). While it works correctly because it's inside the component, it would be more consistent to either memoize it or inline the logic where it's used.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/mui/FormItemTable/index.js` around lines 86 - 92,
calculateTotal currently closes over values and other props and is re-created on
every render; memoize it to avoid stale closures and unnecessary re-computation
by converting it into a useCallback (or replace with an inline useMemo at call
site) that depends on [values, calculateQuantity, currentApplicableRate]; ensure
the memoized function still accepts row and uses
values[`i-${row.form_item_id}-c-global-f-quantity`] || calculateQuantity(row)
and row.rates[currentApplicableRate], and update any usages (where
calculateTotal is called during render) to call the memoized calculateTotal to
keep behavior identical.

src/pages/sponsors/sponsor-cart-tab/components/edit-form/new-cart-form.js (1)

31-33: ⚠️ Potential issue | 🟡 Minor

Refetch should depend on formId.

The effect runs only once. If formId changes on the same mounted instance, sponsor form data will be stale.

#!/bin/bash
# Check effect dependency and fetch call
rg -n "useEffect\\(|getSponsorForm\\(formId\\)|\\], \\[\\]" src/pages/sponsors/sponsor-cart-tab/components/edit-form/new-cart-form.js -C3

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/pages/sponsors/sponsor-cart-tab/components/edit-form/new-cart-form.js`
around lines 31 - 33, The current useEffect in new-cart-form.js calls
getSponsorForm(formId) only on mount, so updates to formId won't refetch; update
the dependency array to [formId] (or [formId, getSponsorForm] if getSponsorForm
isn't stable) so the effect reruns when formId changes, or alternatively memoize
getSponsorForm via useCallback before using it in the effect.

src/components/mui/FormItemTable/index.js (1)

75-89: ⚠️ Potential issue | 🟡 Minor

Include extraColumns in calculateQuantity dependencies.

calculateQuantity reads extraColumns (Line [77]) but the dependency array only tracks valuesStr (Line [88]), so callback logic can go stale when the selected form changes columns.

#!/bin/bash
# Verify current dependency list vs captured variables
rg -n "const calculateQuantity|extraColumns.filter|\\[valuesStr\\]" src/components/mui/FormItemTable/index.js -C3

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/mui/FormItemTable/index.js` around lines 75 - 89, The
calculateQuantity useCallback currently closes over extraColumns but only lists
valuesStr in its dependency array, causing stale behavior; update the dependency
array for calculateQuantity to include extraColumns (e.g., [valuesStr,
extraColumns]) so the callback is recreated when extraColumns changes, ensuring
calculateQuantity (referenced by calculateQuantity and using
extraColumns.filter) always uses the current extraColumns.

src/actions/sponsor-cart-actions.js (1)

296-299: ⚠️ Potential issue | 🟡 Minor

Success toast key does not match this operation.

The success message uses sponsor_list.sponsor_added, which is unrelated to adding a cart form and will show confusing UX copy.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/actions/sponsor-cart-actions.js` around lines 296 - 299, The success
toast currently calls snackbarSuccessHandler with the wrong translation key
("sponsor_list.sponsor_added"); update that call in
src/actions/sponsor-cart-actions.js (the snackbarSuccessHandler invocation) to
use the cart-form-specific key, e.g. replace "sponsor_list.sponsor_added" with
the appropriate cart form success key such as "sponsor_cart.cart_form_added" (or
the existing project i18n key that represents "cart form added") so the UX copy
matches the operation.

Configuration used: defaults

Review profile: CHILL

Plan: Pro